Merged
Conversation
LeonidElkin
added
API: Consistency
LeonidElkin
force-pushed
the
refactoring/strategies-convention
branch
from
17a2ecb to
c710894
Compare
Desiment
reviewed
Mar 1, 2026
Contributor
Desiment
left a comment
Desiment
left a comment
There was a problem hiding this comment.
LGTM for me, but should not we add somewhere in docstrings that there is uniq strategy object for each distribution?
Collaborator
Author
Yeah, sure |
LeonidElkin
force-pushed
the
refactoring/strategies-convention
branch
from
c710894 to
8ba5e15
Compare
Desiment
approved these changes
Mar 9, 2026
LeonidElkin
force-pushed
the
refactoring/strategies-convention
branch
from
8ba5e15 to
fd9f8ea
Compare
LeonidElkin
force-pushed
the
refactoring/strategies-convention
branch
from
fd9f8ea to
4797489
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little bit of refactoring of strategies. Now one strategy for one distribution. If you want to change it you should create a new one distribution via method